Skip to content
Snippets Groups Projects
Select Git revision
  • benchmark-tools
  • postgres-lambda
  • master default
  • REL9_4_25
  • REL9_5_20
  • REL9_6_16
  • REL_10_11
  • REL_11_6
  • REL_12_1
  • REL_12_0
  • REL_12_RC1
  • REL_12_BETA4
  • REL9_4_24
  • REL9_5_19
  • REL9_6_15
  • REL_10_10
  • REL_11_5
  • REL_12_BETA3
  • REL9_4_23
  • REL9_5_18
  • REL9_6_14
  • REL_10_9
  • REL_11_4
23 results

explain.c

Blame
    • Tom Lane's avatar
      e416830a
      Prevent auto_explain from changing the output of a user's EXPLAIN. · e416830a
      Tom Lane authored
      Commit af7914c6, which introduced the
      EXPLAIN (TIMING) option, for some reason coded explain.c to look at
      planstate->instrument->need_timer rather than es->timing to decide
      whether to print timing info.  However, the former flag might get set
      as a result of contrib/auto_explain wanting timing information.  We
      certainly don't want activation of auto_explain to change user-visible
      statement behavior, so fix that.
      
      Also fix an independent bug introduced in the same patch: in the code
      path for a never-executed node with a machine-friendly output format,
      if timing was selected, it would fail to print the Actual Rows and Actual
      Loops items.
      
      Per bug #10404 from Tomonari Katsumata.  Back-patch to 9.2 where the
      faulty code was introduced.
      e416830a
      History
      Prevent auto_explain from changing the output of a user's EXPLAIN.
      Tom Lane authored
      Commit af7914c6, which introduced the
      EXPLAIN (TIMING) option, for some reason coded explain.c to look at
      planstate->instrument->need_timer rather than es->timing to decide
      whether to print timing info.  However, the former flag might get set
      as a result of contrib/auto_explain wanting timing information.  We
      certainly don't want activation of auto_explain to change user-visible
      statement behavior, so fix that.
      
      Also fix an independent bug introduced in the same patch: in the code
      path for a never-executed node with a machine-friendly output format,
      if timing was selected, it would fail to print the Actual Rows and Actual
      Loops items.
      
      Per bug #10404 from Tomonari Katsumata.  Back-patch to 9.2 where the
      faulty code was introduced.