Skip to content
Snippets Groups Projects
  • Tom Lane's avatar
    9dbf2b7d
    Restructure SELECT INTO's parsetree representation into CreateTableAsStmt. · 9dbf2b7d
    Tom Lane authored
    Making this operation look like a utility statement seems generally a good
    idea, and particularly so in light of the desire to provide command
    triggers for utility statements.  The original choice of representing it as
    SELECT with an IntoClause appendage had metastasized into rather a lot of
    places, unfortunately, so that this patch is a great deal more complicated
    than one might at first expect.
    
    In particular, keeping EXPLAIN working for SELECT INTO and CREATE TABLE AS
    subcommands required restructuring some EXPLAIN-related APIs.  Add-on code
    that calls ExplainOnePlan or ExplainOneUtility, or uses
    ExplainOneQuery_hook, will need adjustment.
    
    Also, the cases PREPARE ... SELECT INTO and CREATE RULE ... SELECT INTO,
    which formerly were accepted though undocumented, are no longer accepted.
    The PREPARE case can be replaced with use of CREATE TABLE AS EXECUTE.
    The CREATE RULE case doesn't seem to have much real-world use (since the
    rule would work only once before failing with "table already exists"),
    so we'll not bother with that one.
    
    Both SELECT INTO and CREATE TABLE AS still return a command tag of
    "SELECT nnnn".  There was some discussion of returning "CREATE TABLE nnnn",
    but for the moment backwards compatibility wins the day.
    
    Andres Freund and Tom Lane
    9dbf2b7d
    History
    Restructure SELECT INTO's parsetree representation into CreateTableAsStmt.
    Tom Lane authored
    Making this operation look like a utility statement seems generally a good
    idea, and particularly so in light of the desire to provide command
    triggers for utility statements.  The original choice of representing it as
    SELECT with an IntoClause appendage had metastasized into rather a lot of
    places, unfortunately, so that this patch is a great deal more complicated
    than one might at first expect.
    
    In particular, keeping EXPLAIN working for SELECT INTO and CREATE TABLE AS
    subcommands required restructuring some EXPLAIN-related APIs.  Add-on code
    that calls ExplainOnePlan or ExplainOneUtility, or uses
    ExplainOneQuery_hook, will need adjustment.
    
    Also, the cases PREPARE ... SELECT INTO and CREATE RULE ... SELECT INTO,
    which formerly were accepted though undocumented, are no longer accepted.
    The PREPARE case can be replaced with use of CREATE TABLE AS EXECUTE.
    The CREATE RULE case doesn't seem to have much real-world use (since the
    rule would work only once before failing with "table already exists"),
    so we'll not bother with that one.
    
    Both SELECT INTO and CREATE TABLE AS still return a command tag of
    "SELECT nnnn".  There was some discussion of returning "CREATE TABLE nnnn",
    but for the moment backwards compatibility wins the day.
    
    Andres Freund and Tom Lane