Skip to content
Snippets Groups Projects
Select Git revision
  • benchmark-tools
  • postgres-lambda
  • master default
  • REL9_4_25
  • REL9_5_20
  • REL9_6_16
  • REL_10_11
  • REL_11_6
  • REL_12_1
  • REL_12_0
  • REL_12_RC1
  • REL_12_BETA4
  • REL9_4_24
  • REL9_5_19
  • REL9_6_15
  • REL_10_10
  • REL_11_5
  • REL_12_BETA3
  • REL9_4_23
  • REL9_5_18
  • REL9_6_14
  • REL_10_9
  • REL_11_4
23 results

regexp.c

  • Andrew Gierth's avatar
    dea7fc60
    Repair bug in regexp split performance improvements. · dea7fc60
    Andrew Gierth authored
    Commit c8ea87e4 introduced a temporary conversion buffer for
    substrings extracted during regexp splits. Unfortunately the code that
    sized it was failing to ignore the effects of ignored degenerate
    regexp matches, so for regexp_split_* calls it could under-size the
    buffer in such cases.
    
    Fix, and add some regression test cases (though those will only catch
    the bug if run in a multibyte encoding).
    
    Backpatch to 9.3 as the faulty code was.
    
    Thanks to the PostGIS project, Regina Obe and Paul Ramsey for the
    report (via IRC) and assistance in analysis. Patch by me.
    dea7fc60
    History
    Repair bug in regexp split performance improvements.
    Andrew Gierth authored
    Commit c8ea87e4 introduced a temporary conversion buffer for
    substrings extracted during regexp splits. Unfortunately the code that
    sized it was failing to ignore the effects of ignored degenerate
    regexp matches, so for regexp_split_* calls it could under-size the
    buffer in such cases.
    
    Fix, and add some regression test cases (though those will only catch
    the bug if run in a multibyte encoding).
    
    Backpatch to 9.3 as the faulty code was.
    
    Thanks to the PostGIS project, Regina Obe and Paul Ramsey for the
    report (via IRC) and assistance in analysis. Patch by me.