Skip to content
Snippets Groups Projects
Select Git revision
  • benchmark-tools
  • postgres-lambda
  • master default
  • REL9_4_25
  • REL9_5_20
  • REL9_6_16
  • REL_10_11
  • REL_11_6
  • REL_12_1
  • REL_12_0
  • REL_12_RC1
  • REL_12_BETA4
  • REL9_4_24
  • REL9_5_19
  • REL9_6_15
  • REL_10_10
  • REL_11_5
  • REL_12_BETA3
  • REL9_4_23
  • REL9_5_18
  • REL9_6_14
  • REL_10_9
  • REL_11_4
23 results

command.c

Blame
    • Bruce Momjian's avatar
      bd9b3280
      Here is my much-promised patch to let people add UNIQUE constraints after · bd9b3280
      Bruce Momjian authored
      table creation time.  Big deal you say - but this patch is the basis of the
      next thing which is adding PRIMARY KEYs after table creation time.  (Which
      is currently impossible without twiddling catalogs)
      
      Rundown
      -------
      
      * I have made the makeObjectName function of analyze.c non-static, and
      exported it in analyze.h
      
      * I have included analyze.h and defrem.h into command.c, to support
      makingObjectNames and creating indices
      
      * I removed the 'case CONSTR_PRIMARY' clause so that it properly fails and
      says you can't add primary keys, rather than just doing nothing and
      reporting nothing!!!
      
      * I have modified the docs.
      
      Algorithm
      ---------
      
      * If name specified is null, search for a new valid constraint name.  I'm
      not sure if I should "lock" my generated name somehow tho - should I open
      the relation before doing this step?
      
      * Open relation in access exclusive mode
      
      * Check that the constraint does not already exist
      
      * Define the new index
      
      * Warn if they're doubling up on an existing index
      
      Christopher Kings-Lynne
      bd9b3280
      History
      Here is my much-promised patch to let people add UNIQUE constraints after
      Bruce Momjian authored
      table creation time.  Big deal you say - but this patch is the basis of the
      next thing which is adding PRIMARY KEYs after table creation time.  (Which
      is currently impossible without twiddling catalogs)
      
      Rundown
      -------
      
      * I have made the makeObjectName function of analyze.c non-static, and
      exported it in analyze.h
      
      * I have included analyze.h and defrem.h into command.c, to support
      makingObjectNames and creating indices
      
      * I removed the 'case CONSTR_PRIMARY' clause so that it properly fails and
      says you can't add primary keys, rather than just doing nothing and
      reporting nothing!!!
      
      * I have modified the docs.
      
      Algorithm
      ---------
      
      * If name specified is null, search for a new valid constraint name.  I'm
      not sure if I should "lock" my generated name somehow tho - should I open
      the relation before doing this step?
      
      * Open relation in access exclusive mode
      
      * Check that the constraint does not already exist
      
      * Define the new index
      
      * Warn if they're doubling up on an existing index
      
      Christopher Kings-Lynne