Skip to content
Snippets Groups Projects
Select Git revision
  • benchmark-tools
  • postgres-lambda
  • master default
  • REL9_4_25
  • REL9_5_20
  • REL9_6_16
  • REL_10_11
  • REL_11_6
  • REL_12_1
  • REL_12_0
  • REL_12_RC1
  • REL_12_BETA4
  • REL9_4_24
  • REL9_5_19
  • REL9_6_15
  • REL_10_10
  • REL_11_5
  • REL_12_BETA3
  • REL9_4_23
  • REL9_5_18
  • REL9_6_14
  • REL_10_9
  • REL_11_4
23 results

nodeHash.c

Blame
    • Tom Lane's avatar
      a31e64d0
      Fix some issues in new hashtable size calculations in nodeHash.c. · a31e64d0
      Tom Lane authored
      Limit the size of the hashtable pointer array to not more than
      MaxAllocSize, per reports from Kouhei Kaigai and others of "invalid memory
      alloc request size" failures.  There was discussion of allowing the array
      to get larger than that by using the "huge" palloc API, but so far no proof
      that that is actually a good idea, and at this point in the 9.5 cycle major
      changes from old behavior don't seem like the way to go.
      
      Fix a rather serious secondary bug in the new code, which was that it
      didn't ensure nbuckets remained a power of 2 when recomputing it for the
      multiple-batch case.
      
      Clean up sloppy division of labor between ExecHashIncreaseNumBuckets and
      its sole call site.
      a31e64d0
      History
      Fix some issues in new hashtable size calculations in nodeHash.c.
      Tom Lane authored
      Limit the size of the hashtable pointer array to not more than
      MaxAllocSize, per reports from Kouhei Kaigai and others of "invalid memory
      alloc request size" failures.  There was discussion of allowing the array
      to get larger than that by using the "huge" palloc API, but so far no proof
      that that is actually a good idea, and at this point in the 9.5 cycle major
      changes from old behavior don't seem like the way to go.
      
      Fix a rather serious secondary bug in the new code, which was that it
      didn't ensure nbuckets remained a power of 2 when recomputing it for the
      multiple-batch case.
      
      Clean up sloppy division of labor between ExecHashIncreaseNumBuckets and
      its sole call site.