Skip to content
Snippets Groups Projects
  • Tom Lane's avatar
    8e6b4ee2
    Don't trust CreateFileMapping() to clear the error code on success. · 8e6b4ee2
    Tom Lane authored
    We must test GetLastError() even when CreateFileMapping() returns a
    non-null handle.  If that value were left over from some previous system
    call, we might be fooled into thinking the segment already existed.
    Experimentation on Windows 7 suggests that CreateFileMapping() clears
    the error code on success, but it is not documented to do so, so let's
    not rely on that happening in all Windows releases.
    
    Amit Kapila
    
    Discussion: <20811.1474390987@sss.pgh.pa.us>
    8e6b4ee2
    History
    Don't trust CreateFileMapping() to clear the error code on success.
    Tom Lane authored
    We must test GetLastError() even when CreateFileMapping() returns a
    non-null handle.  If that value were left over from some previous system
    call, we might be fooled into thinking the segment already existed.
    Experimentation on Windows 7 suggests that CreateFileMapping() clears
    the error code on success, but it is not documented to do so, so let's
    not rely on that happening in all Windows releases.
    
    Amit Kapila
    
    Discussion: <20811.1474390987@sss.pgh.pa.us>