Skip to content
Snippets Groups Projects
Select Git revision
  • benchmark-tools
  • postgres-lambda
  • master default
  • REL9_4_25
  • REL9_5_20
  • REL9_6_16
  • REL_10_11
  • REL_11_6
  • REL_12_1
  • REL_12_0
  • REL_12_RC1
  • REL_12_BETA4
  • REL9_4_24
  • REL9_5_19
  • REL9_6_15
  • REL_10_10
  • REL_11_5
  • REL_12_BETA3
  • REL9_4_23
  • REL9_5_18
  • REL9_6_14
  • REL_10_9
  • REL_11_4
23 results

reloptions.c

Blame
    • Michael Paquier's avatar
      707f38e3
      Fix failure with lock mode used for custom relation options · 707f38e3
      Michael Paquier authored
      In-core relation options can use a custom lock mode since 47167b79, that
      has lowered the lock available for some autovacuum parameters.  However
      it forgot to consider custom relation options.  This causes failures
      with ALTER TABLE SET when changing a custom relation option, as its lock
      is not defined.  The existing APIs to define a custom reloption does not
      allow to define a custom lock mode, so enforce its initialization to
      AccessExclusiveMode which should be safe enough in all cases.  An
      upcoming patch will extend the existing APIs to allow a custom lock mode
      to be defined.
      
      The problem can be reproduced with bloom indexes, so add a test there.
      
      Reported-by: Nikolay Sharplov
      Analyzed-by: Thomas Munro, Michael Paquier
      Author: Michael Paquier
      Reviewed-by: Kuntal Ghosh
      Discussion: https://postgr.es/m/20190920013831.GD1844@paquier.xyz
      Backpatch-through: 9.6
      707f38e3
      History
      Fix failure with lock mode used for custom relation options
      Michael Paquier authored
      In-core relation options can use a custom lock mode since 47167b79, that
      has lowered the lock available for some autovacuum parameters.  However
      it forgot to consider custom relation options.  This causes failures
      with ALTER TABLE SET when changing a custom relation option, as its lock
      is not defined.  The existing APIs to define a custom reloption does not
      allow to define a custom lock mode, so enforce its initialization to
      AccessExclusiveMode which should be safe enough in all cases.  An
      upcoming patch will extend the existing APIs to allow a custom lock mode
      to be defined.
      
      The problem can be reproduced with bloom indexes, so add a test there.
      
      Reported-by: Nikolay Sharplov
      Analyzed-by: Thomas Munro, Michael Paquier
      Author: Michael Paquier
      Reviewed-by: Kuntal Ghosh
      Discussion: https://postgr.es/m/20190920013831.GD1844@paquier.xyz
      Backpatch-through: 9.6