Skip to content
Snippets Groups Projects
Select Git revision
  • benchmark-tools
  • postgres-lambda
  • master default
  • REL9_4_25
  • REL9_5_20
  • REL9_6_16
  • REL_10_11
  • REL_11_6
  • REL_12_1
  • REL_12_0
  • REL_12_RC1
  • REL_12_BETA4
  • REL9_4_24
  • REL9_5_19
  • REL9_6_15
  • REL_10_10
  • REL_11_5
  • REL_12_BETA3
  • REL9_4_23
  • REL9_5_18
  • REL9_6_14
  • REL_10_9
  • REL_11_4
23 results

parse_relation.c

Blame
    • Tom Lane's avatar
      1dec7c7c
      Prevent parser from believing that views have system columns. · 1dec7c7c
      Tom Lane authored
      Views should not have any pg_attribute entries for system columns.
      However, we forgot to remove such entries when converting a table to a
      view.  This could lead to crashes later on, if someone attempted to
      reference such a column, as reported by Kohei KaiGai.
      
      This problem is corrected properly in HEAD (by removing the pg_attribute
      entries during conversion), but in the back branches we need to defend
      against existing mis-converted views.  This fix costs us an extra syscache
      lookup per system column reference, which is annoying but probably not
      really measurable in the big scheme of things.
      1dec7c7c
      History
      Prevent parser from believing that views have system columns.
      Tom Lane authored
      Views should not have any pg_attribute entries for system columns.
      However, we forgot to remove such entries when converting a table to a
      view.  This could lead to crashes later on, if someone attempted to
      reference such a column, as reported by Kohei KaiGai.
      
      This problem is corrected properly in HEAD (by removing the pg_attribute
      entries during conversion), but in the back branches we need to defend
      against existing mis-converted views.  This fix costs us an extra syscache
      lookup per system column reference, which is annoying but probably not
      really measurable in the big scheme of things.