Skip to content
Snippets Groups Projects
Select Git revision
  • benchmark-tools
  • postgres-lambda
  • master default
  • REL9_4_25
  • REL9_5_20
  • REL9_6_16
  • REL_10_11
  • REL_11_6
  • REL_12_1
  • REL_12_0
  • REL_12_RC1
  • REL_12_BETA4
  • REL9_4_24
  • REL9_5_19
  • REL9_6_15
  • REL_10_10
  • REL_11_5
  • REL_12_BETA3
  • REL9_4_23
  • REL9_5_18
  • REL9_6_14
  • REL_10_9
  • REL_11_4
23 results

pg_lzcompress.c

  • Heikki Linnakangas's avatar
    3f2adace
    Fix end-of-loop optimization in pglz_find_match() function. · 3f2adace
    Heikki Linnakangas authored
    After the recent pglz optimization patch, the next/prev pointers in the
    hash table are never NULL, INVALID_ENTRY_PTR is used to represent invalid
    entries instead. The end-of-loop check in pglz_find_match() function didn't
    get the memo. The result was the same from a correctness point of view, but
    because the NULL-check would never fail, the tiny optimization turned into
    a pessimization.
    
    Reported by Stephen Frost, using Coverity scanner.
    3f2adace
    History
    Fix end-of-loop optimization in pglz_find_match() function.
    Heikki Linnakangas authored
    After the recent pglz optimization patch, the next/prev pointers in the
    hash table are never NULL, INVALID_ENTRY_PTR is used to represent invalid
    entries instead. The end-of-loop check in pglz_find_match() function didn't
    get the memo. The result was the same from a correctness point of view, but
    because the NULL-check would never fail, the tiny optimization turned into
    a pessimization.
    
    Reported by Stephen Frost, using Coverity scanner.