Skip to content
Snippets Groups Projects
Select Git revision
  • benchmark-tools
  • postgres-lambda
  • master default
  • REL9_4_25
  • REL9_5_20
  • REL9_6_16
  • REL_10_11
  • REL_11_6
  • REL_12_1
  • REL_12_0
  • REL_12_RC1
  • REL_12_BETA4
  • REL9_4_24
  • REL9_5_19
  • REL9_6_15
  • REL_10_10
  • REL_11_5
  • REL_12_BETA3
  • REL9_4_23
  • REL9_5_18
  • REL9_6_14
  • REL_10_9
  • REL_11_4
23 results

readfuncs.c

  • Tom Lane's avatar
    39bfc94c
    Suppress compiler warnings in readfuncs.c. · 39bfc94c
    Tom Lane authored
    Commit 7357558f introduced "(void) token;"
    into the READ_TEMP_LOCALS() macro, to suppress complaints from gcc 4.6
    when the value of token was not used anywhere in a particular node-read
    function.  However, this just moved the warning around: inspection of
    buildfarm results shows that some compilers are now complaining that token
    is being read before it's set.  Revert the READ_TEMP_LOCALS() macro change
    and instead put "(void) token;" into READ_NODE_FIELD(), which is the
    principal culprit for cases where the warning might occur.  In principle we
    might need the same in READ_BITMAPSET_FIELD() and/or READ_LOCATION_FIELD(),
    but it seems unlikely that a node would consist only of such fields, so
    I'll leave them alone for now.
    39bfc94c
    History
    Suppress compiler warnings in readfuncs.c.
    Tom Lane authored
    Commit 7357558f introduced "(void) token;"
    into the READ_TEMP_LOCALS() macro, to suppress complaints from gcc 4.6
    when the value of token was not used anywhere in a particular node-read
    function.  However, this just moved the warning around: inspection of
    buildfarm results shows that some compilers are now complaining that token
    is being read before it's set.  Revert the READ_TEMP_LOCALS() macro change
    and instead put "(void) token;" into READ_NODE_FIELD(), which is the
    principal culprit for cases where the warning might occur.  In principle we
    might need the same in READ_BITMAPSET_FIELD() and/or READ_LOCATION_FIELD(),
    but it seems unlikely that a node would consist only of such fields, so
    I'll leave them alone for now.