Skip to content
Snippets Groups Projects
Select Git revision
  • benchmark-tools
  • postgres-lambda
  • master default
  • REL9_4_25
  • REL9_5_20
  • REL9_6_16
  • REL_10_11
  • REL_11_6
  • REL_12_1
  • REL_12_0
  • REL_12_RC1
  • REL_12_BETA4
  • REL9_4_24
  • REL9_5_19
  • REL9_6_15
  • REL_10_10
  • REL_11_5
  • REL_12_BETA3
  • REL9_4_23
  • REL9_5_18
  • REL9_6_14
  • REL_10_9
  • REL_11_4
23 results

postgres_ext.h

Blame
    • Tom Lane's avatar
      26fa446d
      Add a nonlocalized version of the severity field to client error messages. · 26fa446d
      Tom Lane authored
      This has been requested a few times, but the use-case for it was never
      entirely clear.  The reason for adding it now is that transmission of
      error reports from parallel workers fails when NLS is active, because
      pq_parse_errornotice() wrongly assumes that the existing severity field
      is nonlocalized.  There are other ways we could have fixed that, but the
      other options were basically kluges, whereas this way provides something
      that's at least arguably a useful feature along with the bug fix.
      
      Per report from Jakob Egger.  Back-patch into 9.6, because otherwise
      parallel query is essentially unusable in non-English locales.  The
      problem exists in 9.5 as well, but we don't want to risk changing
      on-the-wire behavior in 9.5 (even though the possibility of new error
      fields is specifically called out in the protocol document).  It may
      be sufficient to leave the issue unfixed in 9.5, given the very limited
      usefulness of pq_parse_errornotice in that version.
      
      Discussion: <A88E0006-13CB-49C6-95CC-1A77D717213C@eggerapps.at>
      26fa446d
      History
      Add a nonlocalized version of the severity field to client error messages.
      Tom Lane authored
      This has been requested a few times, but the use-case for it was never
      entirely clear.  The reason for adding it now is that transmission of
      error reports from parallel workers fails when NLS is active, because
      pq_parse_errornotice() wrongly assumes that the existing severity field
      is nonlocalized.  There are other ways we could have fixed that, but the
      other options were basically kluges, whereas this way provides something
      that's at least arguably a useful feature along with the bug fix.
      
      Per report from Jakob Egger.  Back-patch into 9.6, because otherwise
      parallel query is essentially unusable in non-English locales.  The
      problem exists in 9.5 as well, but we don't want to risk changing
      on-the-wire behavior in 9.5 (even though the possibility of new error
      fields is specifically called out in the protocol document).  It may
      be sufficient to leave the issue unfixed in 9.5, given the very limited
      usefulness of pq_parse_errornotice in that version.
      
      Discussion: <A88E0006-13CB-49C6-95CC-1A77D717213C@eggerapps.at>