Skip to content
Snippets Groups Projects
Select Git revision
  • benchmark-tools
  • postgres-lambda
  • master default
  • REL9_4_25
  • REL9_5_20
  • REL9_6_16
  • REL_10_11
  • REL_11_6
  • REL_12_1
  • REL_12_0
  • REL_12_RC1
  • REL_12_BETA4
  • REL9_4_24
  • REL9_5_19
  • REL9_6_15
  • REL_10_10
  • REL_11_5
  • REL_12_BETA3
  • REL9_4_23
  • REL9_5_18
  • REL9_6_14
  • REL_10_9
  • REL_11_4
23 results

nodeWorktablescan.c

Blame
    • Tom Lane's avatar
      25bf7f8b
      Fix possible failures when a tuplestore switches from in-memory to on-disk · 25bf7f8b
      Tom Lane authored
      mode while callers hold pointers to in-memory tuples.  I reported this for
      the case of nodeWindowAgg's primary scan tuple, but inspection of the code
      shows that all of the calls in nodeWindowAgg and nodeCtescan are at risk.
      For the moment, fix it with a rather brute-force approach of copying
      whenever one of the at-risk callers requests a tuple.  Later we might
      think of some sort of reference-count approach to reduce tuple copying.
      25bf7f8b
      History
      Fix possible failures when a tuplestore switches from in-memory to on-disk
      Tom Lane authored
      mode while callers hold pointers to in-memory tuples.  I reported this for
      the case of nodeWindowAgg's primary scan tuple, but inspection of the code
      shows that all of the calls in nodeWindowAgg and nodeCtescan are at risk.
      For the moment, fix it with a rather brute-force approach of copying
      whenever one of the at-risk callers requests a tuple.  Later we might
      think of some sort of reference-count approach to reduce tuple copying.