Skip to content
Snippets Groups Projects
  • Tom Lane's avatar
    0339047b
    Code review for protransform patches. · 0339047b
    Tom Lane authored
    Fix loss of previous expression-simplification work when a transform
    function fires: we must not simply revert to untransformed input tree.
    Instead build a dummy FuncExpr node to pass to the transform function.
    This has the additional advantage of providing a simpler, more uniform
    API for transform functions.
    
    Move documentation to a somewhat less buried spot, relocate some
    poorly-placed code, be more wary of null constants and invalid typmod
    values, add an opr_sanity check on protransform function signatures,
    and some other minor cosmetic adjustments.
    
    Note: although this patch touches pg_proc.h, no need for catversion
    bump, because the changes are cosmetic and don't actually change the
    intended catalog contents.
    0339047b
    History
    Code review for protransform patches.
    Tom Lane authored
    Fix loss of previous expression-simplification work when a transform
    function fires: we must not simply revert to untransformed input tree.
    Instead build a dummy FuncExpr node to pass to the transform function.
    This has the additional advantage of providing a simpler, more uniform
    API for transform functions.
    
    Move documentation to a somewhat less buried spot, relocate some
    poorly-placed code, be more wary of null constants and invalid typmod
    values, add an opr_sanity check on protransform function signatures,
    and some other minor cosmetic adjustments.
    
    Note: although this patch touches pg_proc.h, no need for catversion
    bump, because the changes are cosmetic and don't actually change the
    intended catalog contents.
parse_clause.h 1.73 KiB