From f4060db11852e65c97d956a5b1d860ebb180e767 Mon Sep 17 00:00:00 2001
From: Andres Freund <andres@anarazel.de>
Date: Sun, 4 Jan 2015 14:36:22 +0100
Subject: [PATCH] Fix inconsequential fd leak in the new
mark_file_as_archived() function.
As every error in mark_file_as_archived() will lead to a failure of
pg_basebackup the FD leak couldn't ever lead to a real problem. It
seems better to fix the leak anyway though, rather than silence
Coverity, as the usage of the function might get extended or copied at
some point in the future.
Pointed out by Coverity.
Backpatch to 9.2, like the relevant part of the previous patch.
---
src/bin/pg_basebackup/receivelog.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/bin/pg_basebackup/receivelog.c b/src/bin/pg_basebackup/receivelog.c
index 9cd0942de3a..b7f43d5aef0 100644
--- a/src/bin/pg_basebackup/receivelog.c
+++ b/src/bin/pg_basebackup/receivelog.c
@@ -65,6 +65,9 @@ mark_file_as_archived(const char *basedir, const char *fname)
{
fprintf(stderr, _("%s: could not fsync file \"%s\": %s\n"),
progname, tmppath, strerror(errno));
+
+ close(fd);
+
return false;
}
--
GitLab