diff --git a/src/backend/bootstrap/bootscanner.l b/src/backend/bootstrap/bootscanner.l index c308f857777ab8651923e8f78af8e7419f59eea2..d3e41d564d546c870382846c3cc03d8e94d51ec1 100644 --- a/src/backend/bootstrap/bootscanner.l +++ b/src/backend/bootstrap/bootscanner.l @@ -105,7 +105,7 @@ insert { return(INSERT_TUPLE); } "toast" { return(XTOAST); } {arrayid} { - yylval.str = pstrdup(MapArrayTypeName(yytext)); + yylval.str = MapArrayTypeName(yytext); return(ID); } {id} { diff --git a/src/backend/bootstrap/bootstrap.c b/src/backend/bootstrap/bootstrap.c index 9339771d585a0bf4860f6ed796ac7e228b04171c..3b4398b80ba034102208e35dcae15ec1fa0c9c55 100644 --- a/src/backend/bootstrap/bootstrap.c +++ b/src/backend/bootstrap/bootstrap.c @@ -1026,38 +1026,33 @@ AllocateAttribute(void) return attribute; } -/* ---------------- +/* * MapArrayTypeName - * XXX arrays of "basetype" are always "_basetype". - * this is an evil hack inherited from rel. 3.1. - * XXX array dimension is thrown away because we - * don't support fixed-dimension arrays. again, - * sickness from 3.1. * - * the string passed in must have a '[' character in it + * Given a type name, produce the corresponding array type name by prepending + * '_' and truncating as needed to fit in NAMEDATALEN-1 bytes. This is only + * used in bootstrap mode, so we can get away with assuming that the input is + * ASCII and we don't need multibyte-aware truncation. * - * the string returned is a pointer to static storage and should NOT - * be freed by the CALLER. - * ---------------- + * The given string normally ends with '[]' or '[digits]'; we discard that. + * + * The result is a palloc'd string. */ char * -MapArrayTypeName(char *s) +MapArrayTypeName(const char *s) { int i, j; - static char newStr[NAMEDATALEN]; /* array type names < NAMEDATALEN long */ + char newStr[NAMEDATALEN]; - if (s == NULL || s[0] == '\0') - return s; - - j = 1; newStr[0] = '_'; - for (i = 0; i < NAMEDATALEN - 1 && s[i] != '['; i++, j++) + j = 1; + for (i = 0; i < NAMEDATALEN - 2 && s[i] != '['; i++, j++) newStr[j] = s[i]; newStr[j] = '\0'; - return newStr; + return pstrdup(newStr); } diff --git a/src/include/bootstrap/bootstrap.h b/src/include/bootstrap/bootstrap.h index 9fe2e0f3f29a01e318125530fae4554611ab86f8..173745d78324b9c58c16a118cb90182ea5c49610 100644 --- a/src/include/bootstrap/bootstrap.h +++ b/src/include/bootstrap/bootstrap.h @@ -40,7 +40,7 @@ extern void InsertOneTuple(Oid objectid); extern void InsertOneValue(char *value, int i); extern void InsertOneNull(int i); -extern char *MapArrayTypeName(char *s); +extern char *MapArrayTypeName(const char *s); extern void index_register(Oid heap, Oid ind, IndexInfo *indexInfo); extern void build_indices(void);