From dbcd9d6160ad940d6216e7f3247409b13f64980e Mon Sep 17 00:00:00 2001 From: Tom Lane <tgl@sss.pgh.pa.us> Date: Sun, 22 Apr 2007 03:52:40 +0000 Subject: [PATCH] Remove some of the most blatant brain-fade in the recent guc patch (it's so nice to have a buildfarm member that actively rejects naked uses of strcasecmp). This coding is still pretty awful, though, since it's going to be O(N^2) in the number of guc variables. May I direct your attention to bsearch? --- src/backend/utils/misc/guc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index 8b1122d86e2..9b1e813dc6c 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -10,7 +10,7 @@ * Written by Peter Eisentraut <peter_e@gmx.net>. * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.387 2007/04/21 20:02:40 petere Exp $ + * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.388 2007/04/22 03:52:40 tgl Exp $ * *-------------------------------------------------------------------- */ @@ -2681,7 +2681,7 @@ guc_get_index(const char *name) int i; for (i = 0; i < num_guc_variables; i++) - if (strcasecmp(name, guc_variables[i]->name) == 0) + if (guc_name_compare(name, guc_variables[i]->name) == 0) return i; return -1; -- GitLab