From d51b0872bf9a71d9585ca13bbf1f9463d9c61182 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut <peter_e@gmx.net>
Date: Wed, 23 Aug 2017 14:59:25 -0400
Subject: [PATCH] Update code comment for temporary replication slots

Reported-by: Alvaro Herrera <alvherre@2ndquadrant.com>
---
 src/include/replication/slot.h | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/include/replication/slot.h b/src/include/replication/slot.h
index 0bf2611fe9c..0c442330b22 100644
--- a/src/include/replication/slot.h
+++ b/src/include/replication/slot.h
@@ -22,9 +22,13 @@
  *
  * Slots marked as PERSISTENT are crash-safe and will not be dropped when
  * released. Slots marked as EPHEMERAL will be dropped when released or after
- * restarts.
+ * restarts.  Slots marked TEMPORARY will be dropped at the end of a session
+ * or on error.
  *
- * EPHEMERAL slots can be made PERSISTENT by calling ReplicationSlotPersist().
+ * EPHEMERAL is used as a not-quite-ready state when creating persistent
+ * slots.  EPHEMERAL slots can be made PERSISTENT by calling
+ * ReplicationSlotPersist().  For a slot that goes away at the end of a
+ * session, TEMPORARY is the appropriate choice.
  */
 typedef enum ReplicationSlotPersistency
 {
-- 
GitLab