From c73fe72e2735d20aa132640d8fab4e0eca1ced95 Mon Sep 17 00:00:00 2001 From: Andrew Dunstan <andrew@dunslane.net> Date: Wed, 2 Feb 2011 12:45:42 -0500 Subject: [PATCH] Add comment on why we're passing a useless 'false' to the plperl function compiler. It's for compatibility with modules like PostgreSQL::PLPerl::NYTProf. --- src/pl/plperl/plperl.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/pl/plperl/plperl.c b/src/pl/plperl/plperl.c index ece3931982e..2ac71685589 100644 --- a/src/pl/plperl/plperl.c +++ b/src/pl/plperl/plperl.c @@ -1422,7 +1422,12 @@ plperl_create_sub(plperl_proc_desc *prodesc, char *s, Oid fn_oid) EXTEND(SP, 4); PUSHs(sv_2mortal(newSVstring(subname))); PUSHs(sv_2mortal(newRV_noinc((SV *) pragma_hv))); - PUSHs(&PL_sv_no); /* XXX is $prolog in mkfunc needed any more? */ + /* + * Use 'false' for $prolog in mkfunc, which is kept for compatibility + * in case a module such as PostgreSQL::PLPerl::NYTprof replaces + * the function compiler. + */ + PUSHs(&PL_sv_no); PUSHs(sv_2mortal(newSVstring(s))); PUTBACK; -- GitLab