From c2a2f7516bd27d4b2bcd387b2aa25a5b98d9c7b0 Mon Sep 17 00:00:00 2001
From: Magnus Hagander <magnus@hagander.net>
Date: Tue, 21 Feb 2012 17:12:25 +0100
Subject: [PATCH] Avoid double close of file handle in syslogger on win32
This causes an exception when running under a debugger or in particular
when running on a debug version of Windows.
Patch from MauMau
---
src/backend/postmaster/syslogger.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c
index cea896a8f97..c331dd9de84 100644
--- a/src/backend/postmaster/syslogger.c
+++ b/src/backend/postmaster/syslogger.c
@@ -588,8 +588,11 @@ SysLogger_Start(void)
errmsg("could not redirect stderr: %m")));
close(fd);
_setmode(_fileno(stderr), _O_BINARY);
- /* Now we are done with the write end of the pipe. */
- CloseHandle(syslogPipe[1]);
+ /*
+ * Now we are done with the write end of the pipe.
+ * CloseHandle() must not be called because the preceding
+ * close() closes the underlying handle.
+ */
syslogPipe[1] = 0;
#endif
redirection_done = true;
--
GitLab