diff --git a/src/backend/executor/execQual.c b/src/backend/executor/execQual.c index 859d3bbc7f1039487fb0fee9ef8a3466f0469662..b1e0cee1562bb781c615a3cdb41c417adc2bd29d 100644 --- a/src/backend/executor/execQual.c +++ b/src/backend/executor/execQual.c @@ -1991,6 +1991,7 @@ ExecMakeFunctionResultNoSets(FuncExprState *fcache, Tuplestorestate * ExecMakeTableFunctionResult(ExprState *funcexpr, ExprContext *econtext, + MemoryContext argContext, TupleDesc expectedDesc, bool randomAccess) { @@ -2072,12 +2073,18 @@ ExecMakeTableFunctionResult(ExprState *funcexpr, /* * Evaluate the function's argument list. * - * Note: ideally, we'd do this in the per-tuple context, but then the - * argument values would disappear when we reset the context in the - * inner loop. So do it in caller context. Perhaps we should make a - * separate context just to hold the evaluated arguments? + * We can't do this in the per-tuple context: the argument values + * would disappear when we reset that context in the inner loop. And + * the caller's CurrentMemoryContext is typically a query-lifespan + * context, so we don't want to leak memory there. We require the + * caller to pass a separate memory context that can be used for this, + * and can be reset each time through to avoid bloat. */ + MemoryContextReset(argContext); + oldcontext = MemoryContextSwitchTo(argContext); argDone = ExecEvalFuncArgs(&fcinfo, fcache->args, econtext); + MemoryContextSwitchTo(oldcontext); + /* We don't allow sets in the arguments of the table function */ if (argDone != ExprSingleResult) ereport(ERROR, diff --git a/src/backend/executor/nodeFunctionscan.c b/src/backend/executor/nodeFunctionscan.c index d51245fb41fe656c612b08cde85806efbd37549a..133a8e22ff76e3766b56bc4c3d92e75f81dba62e 100644 --- a/src/backend/executor/nodeFunctionscan.c +++ b/src/backend/executor/nodeFunctionscan.c @@ -25,6 +25,7 @@ #include "executor/nodeFunctionscan.h" #include "funcapi.h" #include "nodes/nodeFuncs.h" +#include "utils/memutils.h" static TupleTableSlot *FunctionNext(FunctionScanState *node); @@ -64,6 +65,7 @@ FunctionNext(FunctionScanState *node) node->tuplestorestate = tuplestorestate = ExecMakeTableFunctionResult(node->funcexpr, node->ss.ps.ps_ExprContext, + node->argcontext, node->tupdesc, node->eflags & EXEC_FLAG_BACKWARD); } @@ -227,6 +229,19 @@ ExecInitFunctionScan(FunctionScan *node, EState *estate, int eflags) ExecAssignResultTypeFromTL(&scanstate->ss.ps); ExecAssignScanProjectionInfo(&scanstate->ss); + /* + * Create a memory context that ExecMakeTableFunctionResult can use to + * evaluate function arguments in. We can't use the per-tuple context for + * this because it gets reset too often; but we don't want to leak + * evaluation results into the query-lifespan context either. We just + * need one context, because we evaluate each function separately. + */ + scanstate->argcontext = AllocSetContextCreate(CurrentMemoryContext, + "Table function arguments", + ALLOCSET_DEFAULT_MINSIZE, + ALLOCSET_DEFAULT_INITSIZE, + ALLOCSET_DEFAULT_MAXSIZE); + return scanstate; } diff --git a/src/include/executor/executor.h b/src/include/executor/executor.h index 504ee7db7b9c1221b2fe2f8d3ccf6a2b34c35f44..a3a73f344a3afafdb17aad798b3ff15a6ea01a84 100644 --- a/src/include/executor/executor.h +++ b/src/include/executor/executor.h @@ -228,6 +228,7 @@ extern Datum GetAttributeByName(HeapTupleHeader tuple, const char *attname, bool *isNull); extern Tuplestorestate *ExecMakeTableFunctionResult(ExprState *funcexpr, ExprContext *econtext, + MemoryContext argContext, TupleDesc expectedDesc, bool randomAccess); extern Datum ExecEvalExprSwitchContext(ExprState *expression, ExprContext *econtext, diff --git a/src/include/nodes/execnodes.h b/src/include/nodes/execnodes.h index 128ca7fb0a81412613190c30c29f472d8267416f..089f5fadc7fc16cd9b113d8708fad4bda40d027c 100644 --- a/src/include/nodes/execnodes.h +++ b/src/include/nodes/execnodes.h @@ -1391,6 +1391,7 @@ typedef struct SubqueryScanState * tupdesc expected return tuple description * tuplestorestate private state of tuplestore.c * funcexpr state for function expression being evaluated + * argcontext memory context to evaluate function arguments in * ---------------- */ typedef struct FunctionScanState @@ -1400,6 +1401,7 @@ typedef struct FunctionScanState TupleDesc tupdesc; Tuplestorestate *tuplestorestate; ExprState *funcexpr; + MemoryContext argcontext; } FunctionScanState; /* ----------------