From a7f2c79a6eebccd94aade2b03d40a2caeba8a5c3 Mon Sep 17 00:00:00 2001
From: Bruce Momjian <bruce@momjian.us>
Date: Tue, 24 Jan 2012 22:49:55 -0500
Subject: [PATCH] Improve plpython fix comment in pg_upgrade.

---
 contrib/pg_upgrade/function.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/contrib/pg_upgrade/function.c b/contrib/pg_upgrade/function.c
index 4505e51a932..988486b4503 100644
--- a/contrib/pg_upgrade/function.c
+++ b/contrib/pg_upgrade/function.c
@@ -236,6 +236,10 @@ check_loadable_libraries(void)
 		 *	plpython2u pointing to it.  For this reason, any reference to
 		 *	library name "plpython" in an old PG <= 9.1 cluster must look
 		 *	for "plpython2" in the new cluster.
+		 *
+		 *	For this case, we could check pg_pltemplate, but that only works
+		 *	for languages, and does not help with function shared objects,
+		 *	so we just do a general fix.
 		 */
 		if (GET_MAJOR_VERSION(old_cluster.major_version) < 901 &&
 			strcmp(lib, "$libdir/plpython") == 0)
-- 
GitLab