From a486841eb11517e4a344fdebaf370f425a171c85 Mon Sep 17 00:00:00 2001
From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Wed, 31 Dec 2014 14:44:43 -0500
Subject: [PATCH] Print more information about getObjectIdentityParts()
failures.
This might help us debug what's happening on some buildfarm members.
In passing, reduce the message from ereport to elog --- it doesn't seem
like this should be a user-facing case, so not worth translating.
---
src/backend/catalog/objectaddress.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/backend/catalog/objectaddress.c b/src/backend/catalog/objectaddress.c
index c637dbb9ef4..518d060a60d 100644
--- a/src/backend/catalog/objectaddress.c
+++ b/src/backend/catalog/objectaddress.c
@@ -4035,13 +4035,12 @@ getObjectIdentityParts(const ObjectAddress *object,
/*
* If a get_object_address representation was requested, make sure we are
- * providing one. We don't check for objargs, because many of the cases
- * above leave it as NIL.
+ * providing one. We don't check objargs, because many of the cases above
+ * leave it as NIL.
*/
if (objname && *objname == NIL)
- ereport(ERROR,
- (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
- errmsg("requested object address for object type that cannot support it")));
+ elog(ERROR, "requested object address for unsupported object class %d: text result \"%s\"",
+ (int) getObjectClass(object), buffer.data);
return buffer.data;
}
--
GitLab