From 92b503c48d9d98657c59fe630f44b80efaab87de Mon Sep 17 00:00:00 2001
From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Wed, 18 Apr 2018 11:57:37 -0400
Subject: [PATCH] Revert "Add temporary debug logging, in 9.4 branch only."
This reverts commit e55380f3b60108d402f64131fe655b0e5ccc1f31.
It's served its purpose.
---
src/backend/commands/indexcmds.c | 6 ------
src/backend/utils/time/snapmgr.c | 14 --------------
src/include/utils/snapmgr.h | 2 --
3 files changed, 22 deletions(-)
diff --git a/src/backend/commands/indexcmds.c b/src/backend/commands/indexcmds.c
index e8b9d1a4dd8..05afcb0088d 100644
--- a/src/backend/commands/indexcmds.c
+++ b/src/backend/commands/indexcmds.c
@@ -758,8 +758,6 @@ DefineIndex(Oid relationId,
*/
validate_index(relationId, indexRelationId, snapshot);
- PrintSnapMgrStatus("concurrent index build, before snapshot release");
-
/*
* Drop the reference snapshot. We must do this before waiting out other
* snapshot holders, else we will deadlock against other processes also
@@ -772,13 +770,9 @@ DefineIndex(Oid relationId,
limitXmin = snapshot->xmin;
PopActiveSnapshot();
- PrintSnapMgrStatus("concurrent index build, after PopActiveSnapshot");
UnregisterSnapshot(snapshot);
- PrintSnapMgrStatus("concurrent index build, after UnregisterSnapshot");
InvalidateCatalogSnapshot();
- PrintSnapMgrStatus("concurrent index build, after InvalidateCatalogSnapshot");
-
/*
* The index is now valid in the sense that it contains all currently
* interesting tuples. But since it might not contain tuples deleted just
diff --git a/src/backend/utils/time/snapmgr.c b/src/backend/utils/time/snapmgr.c
index 2a3d915e1f9..331c91044f2 100644
--- a/src/backend/utils/time/snapmgr.c
+++ b/src/backend/utils/time/snapmgr.c
@@ -1401,17 +1401,3 @@ HistoricSnapshotGetTupleCids(void)
Assert(HistoricSnapshotActive());
return tuplecid_data;
}
-
-void
-PrintSnapMgrStatus(const char *context)
-{
- int asdepth = 0;
- ActiveSnapshotElt *active;
-
- for (active = ActiveSnapshot; active != NULL; active = active->as_next)
- asdepth++;
-
- elog(LOG, "%s: %d reg snaps, %d active snaps, cat snap %p, xmin %u",
- context, RegisteredSnapshots, asdepth,
- CatalogSnapshot, MyPgXact->xmin);
-}
diff --git a/src/include/utils/snapmgr.h b/src/include/utils/snapmgr.h
index 71452d9afe1..c6aa3619508 100644
--- a/src/include/utils/snapmgr.h
+++ b/src/include/utils/snapmgr.h
@@ -65,6 +65,4 @@ extern void SetupHistoricSnapshot(Snapshot snapshot_now, struct HTAB *tuplecids)
extern void TeardownHistoricSnapshot(bool is_error);
extern bool HistoricSnapshotActive(void);
-extern void PrintSnapMgrStatus(const char *context);
-
#endif /* SNAPMGR_H */
--
GitLab