From 922599464f620bdc7e73ffc65f927e7845fadadf Mon Sep 17 00:00:00 2001
From: Bruce Momjian <bruce@momjian.us>
Date: Sat, 28 Aug 2004 22:52:50 +0000
Subject: [PATCH] Fix high-bit comparison compiler warning in pg_dump.
Philip Warner
---
src/bin/pg_dump/pg_backup_db.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/bin/pg_dump/pg_backup_db.c b/src/bin/pg_dump/pg_backup_db.c
index 6013a909745..7ae61c80825 100644
--- a/src/bin/pg_dump/pg_backup_db.c
+++ b/src/bin/pg_dump/pg_backup_db.c
@@ -5,7 +5,7 @@
* Implements the basic DB functions used by the archiver.
*
* IDENTIFICATION
- * $PostgreSQL: pgsql/src/bin/pg_dump/pg_backup_db.c,v 1.55 2004/08/20 20:00:34 momjian Exp $
+ * $PostgreSQL: pgsql/src/bin/pg_dump/pg_backup_db.c,v 1.56 2004/08/28 22:52:50 momjian Exp $
*
*-------------------------------------------------------------------------
*/
@@ -37,8 +37,8 @@ static void notice_processor(void *arg, const char *message);
static char *_sendSQLLine(ArchiveHandle *AH, char *qry, char *eos);
static char *_sendCopyLine(ArchiveHandle *AH, char *qry, char *eos);
-static int _isIdentChar(char c);
-static int _isDQChar(char c, int atStart);
+static int _isIdentChar(unsigned char c);
+static int _isDQChar(unsigned char c, int atStart);
#define DB_MAX_ERR_STMT 128
@@ -864,14 +864,14 @@ CommitTransactionXref(ArchiveHandle *AH)
destroyPQExpBuffer(qry);
}
-static int _isIdentChar(char c)
+static int _isIdentChar(unsigned char c)
{
if ( (c >= 'a' && c <= 'z')
|| (c >= 'A' && c <= 'Z')
|| (c >= '0' && c <= '9')
|| (c == '_')
|| (c == '$')
- || (c >= '\200' && c <= '\377')
+ || (c >= (unsigned char)'\200') /* no need to check <= \377 */
)
{
return 1;
@@ -882,13 +882,13 @@ static int _isIdentChar(char c)
}
}
-static int _isDQChar(char c, int atStart)
-{
+static int _isDQChar(unsigned char c, int atStart)
+{
if ( (c >= 'a' && c <= 'z')
|| (c >= 'A' && c <= 'Z')
|| (c == '_')
|| (atStart == 0 && c >= '0' && c <= '9')
- || (c >= '\200' && c <= '\377')
+ || (c >= (unsigned char)'\200') /* no need to check <= \377 */
)
{
return 1;
--
GitLab