From 7a764990d8c07c5f8f6c7ff3e8605d482b6778e0 Mon Sep 17 00:00:00 2001 From: Simon Riggs <simon@2ndQuadrant.com> Date: Mon, 3 Dec 2012 12:20:31 +0000 Subject: [PATCH] Clarify locking for PageGetLSN() in XLogCheckBuffer() --- src/backend/access/transam/xlog.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index c8ac97fbf7f..411807006ac 100644 --- a/src/backend/access/transam/xlog.c +++ b/src/backend/access/transam/xlog.c @@ -1212,7 +1212,8 @@ XLogCheckBuffer(XLogRecData *rdata, bool doPageWrites, /* * XXX We assume page LSN is first data on *every* page that can be passed * to XLogInsert, whether it otherwise has the standard page layout or - * not. + * not. We don't need the buffer header lock for PageGetLSN because we + * have exclusive lock on the page and/or the relation. */ *lsn = PageGetLSN(page); -- GitLab