From 790eaa699e4a9626d8a610ec5844e1fd70d73b4e Mon Sep 17 00:00:00 2001
From: Stephen Frost <sfrost@snowman.net>
Date: Sun, 26 Jan 2014 16:26:18 -0500
Subject: [PATCH] Check dup2() results in syslogger
Consistently check the dup2() call results throughout syslogger.c.
It's pretty unlikely that they'll error out, but if they do,
ereport(FATAL) instead of blissfully continuing on.
Spotted by the Coverity scanner.
---
src/backend/postmaster/syslogger.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c
index 54a2b3bd339..3c54956e70f 100644
--- a/src/backend/postmaster/syslogger.c
+++ b/src/backend/postmaster/syslogger.c
@@ -210,8 +210,14 @@ SysLoggerMain(int argc, char *argv[])
close(fileno(stderr));
if (fd != -1)
{
- dup2(fd, fileno(stdout));
- dup2(fd, fileno(stderr));
+ if (dup2(fd, fileno(stdout)) < 0)
+ ereport(FATAL,
+ (errcode_for_file_access(),
+ errmsg("could not redirect stdout: %m")));
+ if (dup2(fd, fileno(stderr)) < 0)
+ ereport(FATAL,
+ (errcode_for_file_access(),
+ errmsg("could not redirect stderr: %m")));
close(fd);
}
}
--
GitLab