From 6fc6686b48bc569b05ce711d18cf964498b217f2 Mon Sep 17 00:00:00 2001
From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Wed, 11 May 2011 14:43:01 -0400
Subject: [PATCH] Clean up parsing of CREATE TRIGGER's argument list.
Use ColLabel in place of ColId, so that reserved words are accepted as if
they were not reserved. Also, remove BCONST and XCONST, which were never
documented as allowed. Allowing those exposes to users an implementation
detail, namely the format in which the lexer outputs such constants, that
seems unwise to expose.
No documentation change needed, since this just makes the code act more
like you'd expect from reading the CREATE TRIGGER man page.
Per complaint from Szymon Guz and subsequent discussion.
---
src/backend/parser/gram.y | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y
index dd959618419..1d39674de4c 100644
--- a/src/backend/parser/gram.y
+++ b/src/backend/parser/gram.y
@@ -4126,9 +4126,7 @@ TriggerFuncArg:
}
| FCONST { $$ = makeString($1); }
| Sconst { $$ = makeString($1); }
- | BCONST { $$ = makeString($1); }
- | XCONST { $$ = makeString($1); }
- | ColId { $$ = makeString($1); }
+ | ColLabel { $$ = makeString($1); }
;
OptConstrFromTable:
--
GitLab