From 4cf0978ea2733548149ee7f11e588975daaf7609 Mon Sep 17 00:00:00 2001
From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Tue, 24 May 2016 15:47:51 -0400
Subject: [PATCH] Fetch XIDs atomically during vac_truncate_clog().
Because vac_update_datfrozenxid() updates datfrozenxid and datminmxid
in-place, it's unsafe to assume that successive reads of those values will
give consistent results. Fetch each one just once to ensure sane behavior
in the minimum calculation. Noted while reviewing Alexander Korotkov's
patch in the same area.
Discussion: <8564.1464116473@sss.pgh.pa.us>
---
src/backend/commands/vacuum.c | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/src/backend/commands/vacuum.c b/src/backend/commands/vacuum.c
index c019b7230bf..7c4f53cab9a 100644
--- a/src/backend/commands/vacuum.c
+++ b/src/backend/commands/vacuum.c
@@ -815,6 +815,12 @@ vac_truncate_clog(TransactionId frozenXID)
/*
* Scan pg_database to compute the minimum datfrozenxid
*
+ * Since vac_update_datfrozenxid updates datfrozenxid in-place,
+ * the values could change while we look at them. Fetch each one just
+ * once to ensure sane behavior of the comparison logic. (Here, as in
+ * many other places, we assume that fetching or updating an XID in shared
+ * storage is atomic.)
+ *
* Note: we need not worry about a race condition with new entries being
* inserted by CREATE DATABASE. Any such entry will have a copy of some
* existing DB's datfrozenxid, and that source DB cannot be ours because
@@ -830,15 +836,16 @@ vac_truncate_clog(TransactionId frozenXID)
while ((tuple = heap_getnext(scan, ForwardScanDirection)) != NULL)
{
- Form_pg_database dbform = (Form_pg_database) GETSTRUCT(tuple);
+ volatile FormData_pg_database *dbform = (Form_pg_database) GETSTRUCT(tuple);
+ TransactionId datfrozenxid = dbform->datfrozenxid;
- Assert(TransactionIdIsNormal(dbform->datfrozenxid));
+ Assert(TransactionIdIsNormal(datfrozenxid));
- if (TransactionIdPrecedes(nextXID, dbform->datfrozenxid))
+ if (TransactionIdPrecedes(nextXID, datfrozenxid))
frozenAlreadyWrapped = true;
- else if (TransactionIdPrecedes(dbform->datfrozenxid, frozenXID))
+ else if (TransactionIdPrecedes(datfrozenxid, frozenXID))
{
- frozenXID = dbform->datfrozenxid;
+ frozenXID = datfrozenxid;
oldest_datoid = HeapTupleGetOid(tuple);
}
}
--
GitLab