From 49232d4191149fd2955e8739a457d70228526dba Mon Sep 17 00:00:00 2001 From: Tom Lane <tgl@sss.pgh.pa.us> Date: Sat, 12 Sep 2015 11:11:08 -0400 Subject: [PATCH] Remove set-but-not-used variable. In branches before 9.3, commit 8703059c6 caused join_is_legal()'s unique_ified variable to become unused, since its only remaining use is for LATERAL-related tests which don't exist pre-9.3. My compiler didn't complain about that, but Peter's does. --- src/backend/optimizer/path/joinrels.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/backend/optimizer/path/joinrels.c b/src/backend/optimizer/path/joinrels.c index e8fa981dea7..e989840029b 100644 --- a/src/backend/optimizer/path/joinrels.c +++ b/src/backend/optimizer/path/joinrels.c @@ -327,7 +327,6 @@ join_is_legal(PlannerInfo *root, RelOptInfo *rel1, RelOptInfo *rel2, { SpecialJoinInfo *match_sjinfo; bool reversed; - bool unique_ified; bool must_be_leftjoin; ListCell *l; @@ -345,7 +344,6 @@ join_is_legal(PlannerInfo *root, RelOptInfo *rel1, RelOptInfo *rel2, */ match_sjinfo = NULL; reversed = false; - unique_ified = false; must_be_leftjoin = false; foreach(l, root->join_info_list) @@ -447,7 +445,6 @@ join_is_legal(PlannerInfo *root, RelOptInfo *rel1, RelOptInfo *rel2, return false; /* invalid join path */ match_sjinfo = sjinfo; reversed = false; - unique_ified = true; } else if (sjinfo->jointype == JOIN_SEMI && bms_equal(sjinfo->syn_righthand, rel1->relids) && @@ -459,7 +456,6 @@ join_is_legal(PlannerInfo *root, RelOptInfo *rel1, RelOptInfo *rel2, return false; /* invalid join path */ match_sjinfo = sjinfo; reversed = true; - unique_ified = true; } else { -- GitLab