From 48bfeb244ff280bad9a81c67442065ae8fcda6b8 Mon Sep 17 00:00:00 2001 From: Andres Freund <andres@anarazel.de> Date: Fri, 1 Jul 2016 14:27:53 -0700 Subject: [PATCH] Improve WritebackContextInit() comment and prototype argument names. Author: Masahiko Sawada Discussion: CAD21AoBD=Of1OzL90Xx4Q-3j=-2q7=S87cs75HfutE=eCday2w@mail.gmail.com --- src/backend/storage/buffer/bufmgr.c | 10 ++++------ src/include/storage/buf_internals.h | 2 +- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c index a67e5181fa9..76ade3727cd 100644 --- a/src/backend/storage/buffer/bufmgr.c +++ b/src/backend/storage/buffer/bufmgr.c @@ -4160,12 +4160,10 @@ ts_ckpt_progress_comparator(Datum a, Datum b, void *arg) /* * Initialize a writeback context, discarding potential previous state. * - * *max_coalesce is a pointer to a variable containing the current maximum - * number of writeback requests that will be coalesced into a bigger one. A - * value <= 0 means that no writeback control will be performed. max_pending - * is a pointer instead of an immediate value, so the coalesce limits can - * easily changed by the GUC mechanism, and so calling code does not have to - * check the current configuration. + * *max_pending is a pointer instead of an immediate value, so the coalesce + * limits can easily changed by the GUC mechanism, and so calling code does + * not have to check the current configuration. A value is 0 means that no + * writeback control will be performed. */ void WritebackContextInit(WritebackContext *context, int *max_pending) diff --git a/src/include/storage/buf_internals.h b/src/include/storage/buf_internals.h index 511d7409e6e..e0dfb2f5b03 100644 --- a/src/include/storage/buf_internals.h +++ b/src/include/storage/buf_internals.h @@ -300,7 +300,7 @@ extern CkptSortItem *CkptBufferIds; * Internal buffer management routines */ /* bufmgr.c */ -extern void WritebackContextInit(WritebackContext *context, int *max_coalesce); +extern void WritebackContextInit(WritebackContext *context, int *max_pending); extern void IssuePendingWritebacks(WritebackContext *context); extern void ScheduleBufferTagForWriteback(WritebackContext *context, BufferTag *tag); -- GitLab