From 39b8cc991fe31ee8df8b0fee467bbd9800fcc1c5 Mon Sep 17 00:00:00 2001 From: Fujii Masao <fujii@postgresql.org> Date: Sat, 4 Feb 2017 03:18:13 +0900 Subject: [PATCH] Be sure to release LogicalRepLauncherLock in DROP SUBSCRIPTION command. Previously DROP SUBSCRIPTION command forgot to release the lock at all. Original patches by Kyotaro Horiguchi and Michael Paquier, but I didn't use them. Discussion: http://postgr.es/m/20170201.173623.66249355.horiguchi.kyotaro@lab.ntt.co.jp --- src/backend/commands/subscriptioncmds.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/backend/commands/subscriptioncmds.c b/src/backend/commands/subscriptioncmds.c index 3b708075653..4353e14e1bd 100644 --- a/src/backend/commands/subscriptioncmds.c +++ b/src/backend/commands/subscriptioncmds.c @@ -514,6 +514,8 @@ DropSubscription(DropSubscriptionStmt *stmt) /* Kill the apply worker so that the slot becomes accessible. */ logicalrep_worker_stop(subid); + LWLockRelease(LogicalRepLauncherLock); + /* Remove the origin tracking if exists. */ snprintf(originname, sizeof(originname), "pg_%u", subid); originid = replorigin_by_name(originname, true); -- GitLab