From 331bf6712c71a1c110bc52423eede8b4bac221a1 Mon Sep 17 00:00:00 2001
From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Wed, 8 Feb 2012 16:19:27 -0500
Subject: [PATCH] Throw error sooner for unlogged GiST indexes.
Throwing an error only after we've built the main index fork is pretty
unfriendly when the table already contains data. Per gripe from Jay
Levitt.
---
src/backend/access/gist/gistbuild.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/src/backend/access/gist/gistbuild.c b/src/backend/access/gist/gistbuild.c
index 021a8dcf44b..3dc3e96df4d 100644
--- a/src/backend/access/gist/gistbuild.c
+++ b/src/backend/access/gist/gistbuild.c
@@ -144,6 +144,16 @@ gistbuild(PG_FUNCTION_ARGS)
elog(ERROR, "index \"%s\" already contains data",
RelationGetRelationName(index));
+ /*
+ * We can't yet handle unlogged GiST indexes, because we depend on LSNs.
+ * This is duplicative of an error in gistbuildempty, but we want to check
+ * here so as to throw error before doing all the index-build work.
+ */
+ if (heap->rd_rel->relpersistence == RELPERSISTENCE_UNLOGGED)
+ ereport(ERROR,
+ (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
+ errmsg("unlogged GiST indexes are not supported")));
+
/* no locking is needed */
buildstate.giststate = initGISTstate(index);
--
GitLab