From 28c480e9ae64fc239fa1ebe32a981312e65ae1e7 Mon Sep 17 00:00:00 2001
From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Sun, 28 Jan 2007 21:17:32 +0000
Subject: [PATCH] Remove unnecessary checkpoint from PL regression tests. This
was once handy to prevent core dump files from disappearing, but it's useless
now because (a) we don't drop core in individual DB subdirectories anymore,
and (b) CREATE DATABASE forces an internal checkpoint anyway.
---
src/pl/plperl/expected/plperl.out | 7 +------
src/pl/plperl/sql/plperl.sql | 6 ------
src/pl/tcl/expected/pltcl_setup.out | 5 -----
src/pl/tcl/sql/pltcl_setup.sql | 6 ------
4 files changed, 1 insertion(+), 23 deletions(-)
diff --git a/src/pl/plperl/expected/plperl.out b/src/pl/plperl/expected/plperl.out
index 7658f36c25d..d7914124104 100644
--- a/src/pl/plperl/expected/plperl.out
+++ b/src/pl/plperl/expected/plperl.out
@@ -1,9 +1,4 @@
--
--- checkpoint so that if we have a crash in the tests, replay of the
--- just-completed CREATE DATABASE won't discard the core dump file
---
-checkpoint;
---
-- Test result value processing
--
CREATE OR REPLACE FUNCTION perl_int(int) RETURNS INTEGER AS $$
@@ -428,7 +423,7 @@ CREATE OR REPLACE FUNCTION array_of_text() RETURNS TEXT[][]
LANGUAGE plperl as $$
return [['a"b',undef,'c,d'],['e\\f',undef,'g']];
$$;
-SELECT array_of_text();
+SELECT array_of_text();
array_of_text
---------------------------------------
{{"a\"b",NULL,"c,d"},{"e\\f",NULL,g}}
diff --git a/src/pl/plperl/sql/plperl.sql b/src/pl/plperl/sql/plperl.sql
index 4d4348a1f6a..df17834952f 100644
--- a/src/pl/plperl/sql/plperl.sql
+++ b/src/pl/plperl/sql/plperl.sql
@@ -1,9 +1,3 @@
---
--- checkpoint so that if we have a crash in the tests, replay of the
--- just-completed CREATE DATABASE won't discard the core dump file
---
-checkpoint;
-
--
-- Test result value processing
--
diff --git a/src/pl/tcl/expected/pltcl_setup.out b/src/pl/tcl/expected/pltcl_setup.out
index ce45aec530d..496cf228dc0 100644
--- a/src/pl/tcl/expected/pltcl_setup.out
+++ b/src/pl/tcl/expected/pltcl_setup.out
@@ -1,9 +1,4 @@
--
--- checkpoint so that if we have a crash in the tests, replay of the
--- just-completed CREATE DATABASE won't discard the core dump file
---
-checkpoint;
---
-- Create the tables used in the test queries
--
-- T_pkey1 is the primary key table for T_dta1. Entries from T_pkey1
diff --git a/src/pl/tcl/sql/pltcl_setup.sql b/src/pl/tcl/sql/pltcl_setup.sql
index b88ebbcffe3..55ac7e20d55 100644
--- a/src/pl/tcl/sql/pltcl_setup.sql
+++ b/src/pl/tcl/sql/pltcl_setup.sql
@@ -1,9 +1,3 @@
---
--- checkpoint so that if we have a crash in the tests, replay of the
--- just-completed CREATE DATABASE won't discard the core dump file
---
-checkpoint;
-
--
-- Create the tables used in the test queries
--
--
GitLab