From 1ca4a1b5d2c633d33161792af1c70e397f879ed9 Mon Sep 17 00:00:00 2001 From: Alvaro Herrera <alvherre@alvh.no-ip.org> Date: Fri, 17 Jun 2016 18:05:55 -0400 Subject: [PATCH] Finish up XLOG_HINT renaming Commit b8fd1a09f3 renamed XLOG_HINT to XLOG_FPI, but neglected two places. Backpatch to 9.3, like that commit. --- src/backend/access/transam/README | 2 +- src/backend/storage/buffer/bufmgr.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/backend/access/transam/README b/src/backend/access/transam/README index 07efebc5c53..4ae4715339e 100644 --- a/src/backend/access/transam/README +++ b/src/backend/access/transam/README @@ -627,7 +627,7 @@ of optimising for performance. When a hint is written we use MarkBufferDirtyHint() to mark the block dirty. If the buffer is clean and checksums are in use then -MarkBufferDirtyHint() inserts an XLOG_HINT record to ensure that we +MarkBufferDirtyHint() inserts an XLOG_FPI record to ensure that we take a full page image that includes the hint. We do this to avoid a partial page write, when we write the dirtied page. WAL is not written during recovery, so we simply skip dirtying blocks because diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c index b7ca9bf04cd..a67e5181fa9 100644 --- a/src/backend/storage/buffer/bufmgr.c +++ b/src/backend/storage/buffer/bufmgr.c @@ -3352,7 +3352,7 @@ IncrBufferRefCount(Buffer buffer) * This is essentially the same as MarkBufferDirty, except: * * 1. The caller does not write WAL; so if checksums are enabled, we may need - * to write an XLOG_HINT WAL record to protect against torn pages. + * to write an XLOG_FPI WAL record to protect against torn pages. * 2. The caller might have only share-lock instead of exclusive-lock on the * buffer's content lock. * 3. This function does not guarantee that the buffer is always marked dirty -- GitLab