From 06f5fd2f4f3d0991af07456e7cf6632b4ad9d7e7 Mon Sep 17 00:00:00 2001
From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Sat, 5 Nov 2016 11:14:10 -0400
Subject: [PATCH] pgwin32_is_junction's argument should be "const char *" not
"char *".
We're passing const strings to it in places, and that's not an
unreasonable thing to do. Per buildfarm (noted on frogmouth
in particular).
---
src/include/port.h | 2 +-
src/port/dirmod.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/include/port.h b/src/include/port.h
index b81fa4a89eb..8a63958535b 100644
--- a/src/include/port.h
+++ b/src/include/port.h
@@ -251,7 +251,7 @@ extern int pgunlink(const char *path);
#if defined(WIN32) && !defined(__CYGWIN__)
extern int pgsymlink(const char *oldpath, const char *newpath);
extern int pgreadlink(const char *path, char *buf, size_t size);
-extern bool pgwin32_is_junction(char *path);
+extern bool pgwin32_is_junction(const char *path);
#define symlink(oldpath, newpath) pgsymlink(oldpath, newpath)
#define readlink(path, buf, size) pgreadlink(path, buf, size)
diff --git a/src/port/dirmod.c b/src/port/dirmod.c
index fe2b815ff6a..aaf496df667 100644
--- a/src/port/dirmod.c
+++ b/src/port/dirmod.c
@@ -338,10 +338,10 @@ pgreadlink(const char *path, char *buf, size_t size)
/*
* Assumes the file exists, so will return false if it doesn't
- * (since a nonexistant file is not a junction)
+ * (since a nonexistent file is not a junction)
*/
bool
-pgwin32_is_junction(char *path)
+pgwin32_is_junction(const char *path)
{
DWORD attr = GetFileAttributes(path);
--
GitLab