From 0262251c337ca066d1b1698684784254849b5676 Mon Sep 17 00:00:00 2001 From: Bruce Momjian <bruce@momjian.us> Date: Wed, 20 Apr 2011 05:44:45 -0400 Subject: [PATCH] Pg_upgrade C comment addition. Document why we do the missing new database check during the check phase. --- contrib/pg_upgrade/check.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/contrib/pg_upgrade/check.c b/contrib/pg_upgrade/check.c index 173b29a2c5f..d1dc5dbeaac 100644 --- a/contrib/pg_upgrade/check.c +++ b/contrib/pg_upgrade/check.c @@ -372,7 +372,9 @@ check_new_cluster_is_empty(void) * the new cluster has a 'postgres' database, the number of databases * will not match. We actually could upgrade such a setup, but it would * violate the 1-to-1 mapping of database counts, so we throw an error - * instead. + * instead. We would detect this as a database count mismatch during + * upgrade, but we want to detect it during the check phase and report + * the database name. */ static void check_old_cluster_has_new_cluster_dbs(void) -- GitLab